Add OWNERS file #45
Merged
Add OWNERS file #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
thockin
approved these changes
Aug 14, 2018
|
/hold Can we add a non-googler to this review/approver. |
k8s-ci-robot
added
the
do-not-merge/hold
spiffxp
force-pushed
the
add-owners-file
branch
from
7bf5107 to
0c6bd43
Compare
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
lgtm
|
@deads2k ack, I added you FWIW I'm just trying to get something in place that represents the state of who has merged in the past. I am in highly in favor of this list representing interested owners, and would encourage you all to revise this as needed |
|
(this repo isn't yet setup to use /approve precisely because it lacks OWNERS, so if y'all are ok with it I can manually merge) |
|
I'd like to be somewhere in the file because clock is my baby from way back. I am fine with you manually merging. |
Populated based upon users who have previously merged code in this repo Added lavalamp based on review feedback
spiffxp
force-pushed
the
add-owners-file
branch
from
0c6bd43 to
21abee4
Compare
|
Added @lavalamp Will manually merge and turn on /approve automation for this repo. We can then iterate on this as needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populated based upon users who have previously merged code in this repo
Fixes #44